Creates Automating Subusers Page#4182
Creates Automating Subusers Page#4182apigirl merged 10 commits intosendgrid:developfrom crweiner:automating-subusers
Conversation
| ```bash | ||
| => 2xx | ||
|
|
||
| {"id":50784,"user_id":624781,"subdomain":"subdomain","domain":"staples.com","username":"ryan.burrer","ips":["167.89.38.39","198.37.152.144"],"custom_spf":false,"default":true,"legacy":false,"automatic_security":true,"valid":false, |
There was a problem hiding this comment.
for all of the usernames and domain names, can you change them to some form of "example" please?
| } | ||
| ``` | ||
|
|
||
| 5. **Validate ID of domain Whitelabel** |
There was a problem hiding this comment.
Add another line between this and the one above. Currently running into one another on one line.
Whatthefoxsays
left a comment
Whatthefoxsays
left a comment
There was a problem hiding this comment.
GREAT start! Thanks for taking this on! Just a few small changes. Please let us know if you have questions.
|
Hi @Whatthefoxsays! You're awesome to review all of this for me, thank you! I'll get on making those changes in the next few days. 👍 |
apigirl
dismissed
Whatthefoxsays’s stale review
everything has been addressed!
apigirl
added
difficulty: hard
hacktoberfest
status: hacktoberfest approved
|
Hello @crweiner, |
|
Thank you again @Whatthefoxsays and @ksigler7 for reviewing this! Really, I greatly do appreciate your time and help!! I just wanted to make sure of one thing that popped up, does the Username field at Line 489 here return the email address in question, or is it actually the username from Line 38 here ? I just want to make sure that I have that correctly. Also, this is the first time I've tried to use the Review feature of Github, so if I did something wrong, please let me know so I can correct it! Once everything is good to go, I'll be happy to remove the "[Do Not Merge]" from the PR title. |
|
@crweiner - lgtm! you have the username correctly. Thank you SO much for all of your effort on this!! |
crweiner
changed the title
4 participants
## Do Not Merge YetPlease review this PR and page to make sure that it meets what you were looking for before any merger. Please let me know any and all changes that need to be made and I will be happy to do so. Opening this up as a PR just makes it easier to share my Commits/edits and contributions with you so we can collaborate.
I will remove the [Do Not Merge] tag from the title once I get the thumbs up from you. 👍
Description of the change:
Per #4175, this PR creates a page called Automating Subusers and includes the
curlreferences in proper Markdown, stylized for Github.Closes #4175